Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47088 )
Change subject: libpayload/keyboard: Implement self-test ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47088/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47088/1/payloads/libpayload/drivers... PS1, Line 455: state_time = timer_us(0); We could also keep starting in STATE_CONFIGURE and let it fall back to the self-test on error.