Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36007 )
Change subject: soc/intel/braswell: Use common sb code for SPI lockdown configuration
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36007/3/src/mainboard/facebook/fbg1...
File src/mainboard/facebook/fbg1701/w25q64.c:
https://review.coreboot.org/c/coreboot/+/36007/3/src/mainboard/facebook/fbg1...
PS3, Line 66: .preop = CMD_W25_WREN,
The pre-op for this platform is WREN only!
Why changing this?
I didn't notice it, since all those files are called w25q64.c and made assumptions on the flash used. I could use the callback function to override the defaults. Why is it needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e7be41a9470b37ad954d3120a67fc4d93633113
Gerrit-Change-Number: 36007
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 12:33:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment