Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39888 )
Change subject: ec/google/chromeec: Emit SSDT for PS2 keyboard if needed
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39888/3/src/ec/google/chromeec/ec_a...
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/39888/3/src/ec/google/chromeec/ec_a...
PS3, Line 219: if (google_chromeec_get_num_pd_ports(&num_ports))
: return;
unless the ps2kb ssdt generator will only be used for newer devices (which will always have at least 1 PD port), will need to change this conditional
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I792e6701b6b8b3686222c554223e07370b9b9813
Gerrit-Change-Number: 39888
Gerrit-PatchSet: 3
Gerrit-Owner: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Mar 2020 23:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment