Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Michael Niewöhner, Robbie Zhang, Paul Menzel, Christian Walter, Pratik Prajapati, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35312
to look at the new patch set (#9).
Change subject: soc/intel/common/block/sgx: Fix crash in MP init ......................................................................
soc/intel/common/block/sgx: Fix crash in MP init
On Hyper-Threading enabled platforms the MSR_PRMRR_PHYS_MASK was written when already locked by the sibling thread. In addition it loads microcode updates on all threads.
To prevent such race conditions only call the code on one thread, such that the MSRs are only written once per core and the microcode is only loaded once for each core.
Also add comments that describe the scope of the MSR that is being written to and mention the Intel documents used for reference.
Fixes crash in SGX MP init. Tested on Supermicro X11SSH-TF.
Change-Id: I7102da028a449c60ca700b3f9ccda9017aa6d6b5 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/soc/intel/common/block/sgx/Kconfig M src/soc/intel/common/block/sgx/sgx.c 4 files changed, 52 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/35312/9