[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add SSDT generation for Intel USB4 PCIe ports

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44915 )

Change subject: soc/intel/common: Add SSDT generation for Intel USB4 PCIe ports
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... 
File src/soc/intel/common/block/usb4/Kconfig:

https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... 
PS12, Line 12: HAVE_ACPI_TABLES
> Not required since the driver is doing more than just handling ACPI tables?

Oops yep forget to remove it here when I added the #if CONFIGs below.

https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... 
File src/soc/intel/common/block/usb4/pcie.c:

https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... 
PS12, Line 83: scan_generic_bus
> Should this be scan_static_bus since that will allow walking downstream from the child in case it is […]

Done