Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38015 )
Change subject: nb/intel/sandybridge: add and use memory thermal configuration registers
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38015/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/38015/1/src/northbridge/intel/sandy...
PS1, Line 141: #define MEM_TRML_THRESHOLDS_CONFIG 0x5888
I see a tab whitespace before MEM_
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96efeadcc7d22bc8453645f6a0884d82edf3aec6
Gerrit-Change-Number: 38015
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 31 Dec 2019 12:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment