Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32223 )
Change subject: libpayload/drivers/timer: Use 64 bits to prevent overflow
......................................................................
Patch Set 2:
Patch Set 1:
do we need 64 bits also here? :
nano +283 src/arch/x86/cpu.c
Hmmm, possibly. How large is an unsigned long in this case? Even if we make the multiplication 64 bits, it will be implicitly cast to 32 bits inside the tsc_info struct anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadb0abb7c7cc078f31a6d88d971f5d1b8ac62a9e
Gerrit-Change-Number: 32223
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 08 Apr 2019 19:04:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment