[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add SD card support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )

Change subject: mb/google/dedede: Add SD card support
......................................................................

Patch Set 26:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
PS23, Line 284: GPP_G7
> Furquan , I further checked setting the WP as NF1 and adding a 20K PD. […]

Do you understand what the errors mean? And how GPP_G7/SD_SDIO_WP was causing those?

https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... 
PS25, Line 272: NATIVE
> correct. I added the native termination for SD clk as well. EDS(vol 1 10.4. […]

Thanks Aamir! Can you please add the reference to the EDS section as well in the comment here?