Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33165 )
Change subject: mediatek: Support GPIO based SPI CS
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33165/2/src/soc/mediatek/common/include/soc/...
File src/soc/mediatek/common/include/soc/spi_common.h:
https://review.coreboot.org/#/c/33165/2/src/soc/mediatek/common/include/soc/...
PS2, Line 81: gpio_t *cs_gpio;
Like mentioned in the depthcharge CL, I think we should just do this unconditionally. Then this doesn't need to be a pointer, just a gpio_t.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61653fb19242b6ee6be9a45545a8b66e5c9c7cad
Gerrit-Change-Number: 33165
Gerrit-PatchSet: 2
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment