Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar() ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34808/7/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/7/src/cpu/intel/car/romstage.... PS7, Line 25: static struct postcar_frame early_mtrrs; Now that the flow is refactored I do think there's not point in making this object sit in .bss, but if you like it here it certainly can remain.
https://review.coreboot.org/c/coreboot/+/34808/7/src/cpu/intel/car/romstage.... PS7, Line 27: prepare_postcar name change like the other comment.
https://review.coreboot.org/c/coreboot/+/34808/7/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/7/src/soc/intel/baytrail/roms... PS7, Line 56: prepare_postcar
Minor: prepare_and_run_postcar ?
ya. need to update comment