Attention is currently required from: Raul Rangel, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43050 )
Change subject: soc/amd/common: Refactor program_gpios() for overrides
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
finally got around to have a look and I like the general direction this patch, since it avoids unnee […]
Thanks, please take over.
I don't know about the intended behaviour or motivation behind it. If you need a new GPIO implemented for a variant, you need to add entry in the baseboard GPIOs too and thus introduce change in other veriants too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e47b2a278a1887db5406c1f863ddafa6a68675
Gerrit-Change-Number: 43050
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 19 Sep 2021 04:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment