Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37358 )
Change subject: src/: Remove g_ prefixes and _g suffixes from variables
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37358/1/src/cpu/intel/common/fsb.c
File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/c/coreboot/+/37358/1/src/cpu/intel/common/fsb.c@...
PS1, Line 102: car_set_var(timer_fsb, fsb);
There's a commit by Arthur to sort these out, and once that goes in, this commit will be updated.
Ack
https://review.coreboot.org/c/coreboot/+/37358/1/src/drivers/elog/elog.c
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/37358/1/src/drivers/elog/elog.c@97
PS1, Line 97: elog_state.mirror_last_write);
I'll need to check if coccinelle has a 80 column limit somewhere that I should override.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4936ff9780a0d3ed9b8b539772bc48887f8d5eed
Gerrit-Change-Number: 37358
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 Nov 2019 16:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment