Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37562 )
Change subject: EC sync: Properly handle VBERROR return codes from vb2api_ec_sync ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37562/1/src/security/vboot/ec_sync.... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/37562/1/src/security/vboot/ec_sync.... PS1, Line 69: vboot_reboot();
This seems a bit odd for error handling? If you do want to reboot, you should at least vb2api_fail() […]
Agreed, that really shouldn't happen, I'll change to just print on an error and halt() regardless.
https://review.coreboot.org/c/coreboot/+/37562/1/src/security/vboot/ec_sync.... PS1, Line 71: poweroff();
poweroff() is not available on all coreboot platforms, so putting this here would prevent us from us […]
Ack
https://review.coreboot.org/c/coreboot/+/37562/1/src/security/vboot/ec_sync.... PS1, Line 86: poweroff();
This has the same problem with poweroff(). […]
Ah yes, that's from battery cutoff, not needed in just this flow. Removed.
https://review.coreboot.org/c/coreboot/+/37562/1/src/security/vboot/ec_sync.... PS1, Line 95: if (retval != VB2_SUCCESS) {
nit: maybe just put a […]
Done