Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 41:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/6c7b5636_1d2b897e PS41, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/2695f7bb_b16c78ee PS41, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/2b613b4d_4d12ccc4 PS41, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/2c49e2fe_ed484e42 PS41, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f7eb49b6_4d7d1d60 PS41, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/15ffc25c_fc482a83 PS41, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/12cc77d7_34733784 PS41, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/691db941_f49b19f2 PS41, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/414322a3_7e2884ae PS41, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/447ce84f_674faaa8 PS41, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/901a8c4f_29012187 PS41, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/8b2f2a11_54596b55 PS41, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/1ec77aee_9f7b089f PS41, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/c89a1b9b_4d3b08f6 PS41, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/0c954f08_2791eeab PS41, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/493fba2d_c970fbfd PS41, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/04e04c40_47565211 PS41, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/c303f6fc_0da4116b PS41, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f8155c2c_31fb11b8 PS41, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/c1e5610f_7d8c6d2a PS41, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f7708135_3a48b44e PS41, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/c6c59b38_dcc6bfb6 PS41, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/7b54c5b2_037169ca PS41, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f3da3576_cb2bc870 PS41, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/d1810e23_3b263073 PS41, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/3fa289ed_d93b1f06 PS41, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/d3333c82_488cf850 PS41, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/a5fc0a62_b81950b2 PS41, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/b5d6cf72_b83b7790 PS41, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/e0d998df_145cbbc1 PS41, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f21eb117_5508e1a8 PS41, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/b547ed0a_29fdd07a PS41, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/48d302f3_73605614 PS41, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/634c88b3_841456dd PS41, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/f63261f4_52eaf570 PS41, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/cd52a810_f77620d5 PS41, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/d7f0d4cc_3267d2b1 PS41, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/d48c0c3f_da7c7823 PS41, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/09ad31df_9ffab0a8 PS41, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/8c0afeeb_98c50d57 PS41, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/6e789262_23fe086d PS41, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120301): https://review.coreboot.org/c/coreboot/+/49768/comment/fd4f8d9b_b9658888 PS41, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line