Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )
Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG@11 PS1, Line 11: static files that are not intended to be updated to the RW regions. The problem statement seems to be that one wants to put files in different CBFSes. Some of those files reside in RO while others may be in RW. But the desire is to locate the files using the same API regardless of which CBFS it is in.
Why not just target the specific region? cbfs_locate_file_in_region()
If anything, this fallback path should be guarded with a Kconfig option. On the Chromebook side of things we wouldn't want to implicitly pull things from different regions. Once we've steered to a specific CBFS region from vboot we don't want to implicitly go back to another region. We would only want to target different CBFS regions explicitly.
https://review.coreboot.org/c/coreboot/+/36545/1/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/36545/1/src/lib/cbfs.c@67 PS1, Line 67: printk(BIOS_DEBUG, "CBFS_BOOT_LOCATE: Fall back to RO region\n"); ret = cbfs_locate_file_in_region(fh, "COREBOOT", name, type);