Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33777 )
Change subject: asus/am1i-a: remove default VGA_BIOS_ID to make it the same as family16kb ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patch Set 2:
Patch Set 2:
now, we probably need to add the ID 1002,9836 for some Sempron into this file src/northbridge/amd/agesa/family16kb/Kconfig
No, we don't need to change anything there, since there is already a good 1002,9830 ID. This Sempron is less popular and less powerful than these three Athlons, so Athlon ID should be preferred.
I think 9830 is a good default (three out of five APUs have that id) but I would probably document the other two IDs somewhere. Maybe in Documentation?
https://review.coreboot.org/#/c/33777/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33777/2//COMMIT_MSG@7 PS2, Line 7: remove default VGA_BIOS_ID to make it the same as family16kb remove unnecessary VGA_BIOS_ID default
https://review.coreboot.org/#/c/33777/2//COMMIT_MSG@9 PS2, Line 9: (three Athlons, the : most powerful for this socket) It doesn't matter much if they are the most powerful ones or not.
https://review.coreboot.org/#/c/33777/2//COMMIT_MSG@11 PS2, Line 11: Remove it to make it 9830 like family16kb. Since VGA_BIOS_ID is already defined in fam16kb Kconfig, drop the value here.