Patch Set 2:

Patch Set 2:

now, we probably need to add the ID 1002,9836 for some Sempron into this file src/northbridge/amd/agesa/family16kb/Kconfig

No, we don't need to change anything there, since there is already a good 1002,9830 ID. This Sempron is less popular and less powerful than these three Athlons, so Athlon ID should be preferred.

I think 9830 is a good default (three out of five APUs have that id) but I would probably document the other two IDs somewhere. Maybe in Documentation?

Patch set 2:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 7: remove default VGA_BIOS_ID to make it the same as family16kb

    remove unnecessary VGA_BIOS_ID default

  • Patch Set #2, Line 9:

    (three Athlons, the
    most powerful for this socket)
    

    It doesn't matter much if they are the most powerful ones or not.

  • Patch Set #2, Line 11: Remove it to make it 9830 like family16kb.

    Since VGA_BIOS_ID is already defined in fam16kb Kconfig, drop the value here.

To view, visit change 33777. To unsubscribe, or for help writing mail filters, visit settings.