[coreboot-gerrit] Change in coreboot[master]: drivers/intel/usb4: Add driver for USB4 retimer device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )

Change subject: drivers/intel/usb4: Add driver for USB4 retimer device
......................................................................

Patch Set 13:

(4 comments)

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
PS12, Line 43: 0x03
> 1 function beyond the standard query would be 0x3, if it's only the standard query, you can return 0 […]

Makes sense to me.

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
PS13, Line 31: 0x07
0x03

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
PS13, Line 33: 0x01
0x00

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
PS13, Line 39: 0x07
0x03?