Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38300 )
Change subject: timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c
File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c@131
PS1, Line 131: tse->entry_stamp = ts_time - ts_table->base_time;
If I visualize this correctly, timestamps prior to CBMEM coming online will have ts_table->base_time […]
Ack
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c@154
PS1, Line 154: printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time);
The Kconfig option description needs to be updated accordingly.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72ca4b6a04d8734c141a04e651fc8c23932b1f23
Gerrit-Change-Number: 38300
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Thu, 09 Jan 2020 13:37:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment