22 Oct
2021
22 Oct
'21
7:52 a.m.
Attention is currently required from: Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55551 )
Change subject: amdfwtool: Add psp id for combo and ISH header for AB recovery ......................................................................
Patch Set 10:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/55551/comment/213ffa97_1d1951a2 PS9, Line 1627: /* TODO: PSP ID. Documentation is needed. */
is this comment still needed? with this commit adding get_psp_id this is no longer just hard-coded v […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/55551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3082b850fb3fd2d7ae83a1c4dfd89eb7e1bd0f97
Gerrit-Change-Number: 55551
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bao Zheng zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 22 Oct 2021 04:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment