Attention is currently required from: Paul Menzel, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62934 )
Change subject: soc/mediatek/mt8195: Reserve memory to store PCIe timestamp
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8195/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/62934/comment/5dcb1d73_65332d1c
PS1, Line 33: 4
I think the system won't do an atomic read/write in that case.
Probably better aligned to 8 bytes or even 16 bytes, for example
0x00104010
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia97468742e144d8343f5c7ae6db7cb82a316cf5c
Gerrit-Change-Number: 62934
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 19 Mar 2022 05:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment