24 Jul
2020
24 Jul
'20
9:36 p.m.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42832 )
Change subject: mb/google/zork: Add Bluetooth reset gpios to devicetree ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42832/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/42832/3/src/mainboard/google/zork/v... PS3, Line 272: GPIO_14
You might want to consider adding `variant_bluetooth_update()` called from `mainboard_devtree_update […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/42832
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14e3ef099d5b8f48c915b41284039b3508dec975
Gerrit-Change-Number: 42832
Gerrit-PatchSet: 9
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment