hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 36: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/in... PS34, Line 166: r
R
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/pmif_spi.h:
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/in... PS34, Line 68:
Use tabs to align.
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... File src/soc/mediatek/mt8192/pmif.c:
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 15: int
long
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 15: long
int
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 33: ret
Use "int" type.
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 33: data
Use u32.
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 44: {
Remove these.
Done
https://review.coreboot.org/c/coreboot/+/45398/34/src/soc/mediatek/mt8192/pm... PS34, Line 178: controller
controller: inf = %d, mstid = %d
Done