[coreboot-gerrit] Change in coreboot[master]: lib/cbmem_top: Add a common cbmem_top implementation

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )

Change subject: lib/cbmem_top: Add a common cbmem_top implementation
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36273/13//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36273/13//COMMIT_MSG@16 
PS13, Line 16: if CONFIG_RAMSTAGE_CBMEM_TOP_ARG is not set the
             : same implementation as will be used as in romstage.
             :
> I think the naming of your source of cbmem top is the issue. We shouldn't be using functions named _romstage() in stages other than romstage. It just causes confusion.

I see. What about a 'new' optional callback cbmem_top_ramstage that will in this case return cbmem_top_romstage? At the moment only RISCV (which does not even initialize cbmem in romstage on some targets) and NVIDIA tegra210 need it.