22 Feb
2020
22 Feb
'20
11:21 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39030 )
Change subject: src: capitalize 'APIC' ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39030/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/acpi/cpu-hotplug.asl:
https://review.coreboot.org/c/coreboot/+/39030/1/src/mainboard/emulation/qem... PS1, Line 29: madt This should be MADT (handle in another change)
https://review.coreboot.org/c/coreboot/+/39030/1/src/mainboard/emulation/qem... PS1, Line 31: lapic This is "Local APIC". Maybe you want to update it as well?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I487fb53bb2b011d214f002fc200ade2f128a4cc6
Gerrit-Change-Number: 39030
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 22 Feb 2020 22:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment