Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38702 )
Change subject: soc/amd/picasso: Add bootram reservations ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38702/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38702/5//COMMIT_MSG@10 PS5, Line 10: must be reserved from use by the OS. During bootblock, save the region Add reason why? (S3 resume would corrupt it).
Unless you are close to having working ACPI S3 there should be no rush to merge this without proper discussion.
https://review.coreboot.org/c/coreboot/+/38702/5//COMMIT_MSG@13 PS5, Line 13: retrieve the bases and sizes, then add them as BM_MEM_RESERVED. This is not really a picasso issue that would justify use of a vendor-specific solution via biosram. It is a generic problem, feature like wiping DRAM late in romstage would benefit of having bootmem accounting available, on every platform, also non-X86.
You can achieve this with CBMEM and place set_bootmem_() calls in common code.
If I could, this would be -2. Practise has shown that wiping out vendor-specific approaches in favour of generic ones is expensive and wastes review resources. And causes tensions allover.