Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Subrata Banik.
Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email )
Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/78297/comment/f300b1ab_3fefb52e :
PS1, Line 374: if (config->wake_gpio.pin_count)
I don't think this check is suffiencient. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78297?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e
Gerrit-Change-Number: 78297
Gerrit-PatchSet: 2
Gerrit-Owner: Paweł Anikiel
panikiel@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
czapiga@google.com
Gerrit-CC: Kornel Dulęba
korneld@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kornel Dulęba
korneld@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 16 Oct 2023 15:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kornel Dulęba
korneld@google.com
Gerrit-MessageType: comment