[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )

Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85978/comment/f6a8ead7_eb2730f3?usp... :
PS1, Line 9: rtc
> will update

keep comment unresolved

File src/soc/mediatek/mt8196/include/soc/mt6685_rtc_hw.h:

PS1:
> will update is next version, as discussion in meeting,  first update a version for the previous 56 c […]

keep comment unresolved

File src/soc/mediatek/mt8196/mt6685_rtc.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/d89f805d_57f33bae?usp... :
PS1, Line 68: 			     RG_BANK_FQMTR_RST_SHIFT);
> Acknowledged

keep comment unresolved

https://review.coreboot.org/c/coreboot/+/85978/comment/078aa1ca_3b41b929?usp... :
PS1, Line 233: rtc_read(RTC_AL_SEC, &rdata);
             : 
             : 	rtc_write(RTC_AL_SEC, (rdata & (~RTC_LPD_OPT_MASK)) | RTC_LPD_OPT_EOSC_LPD);
             : 	if (!rtc_write_trigger())
> will update

keep comment unresolved

File src/soc/mediatek/mt8196/mt6685_rtc.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/4cbd9d2f_5d0b86a5?usp... :
PS2, Line 193: RTC_CON_GPU
align

https://review.coreboot.org/c/coreboot/+/85978/comment/b834dcaa_fdecadee?usp... :
PS2, Line 358: rtc_init_after_recovery
align or move to above line