Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Curtis Chen.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57584 )
Change subject: mb/google/brya: Create APIs for USB-C DP alternate mode support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57584/comment/16ead6bc_0960cabb
PS3, Line 10: #include <ec/google/chromeec/ec.h>
: #include <intelblocks/tcss.h>
: #include <delay.h>
: #include <timer.h>
nit: in alphabetical order with the rest (best you can)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I496efa08987d7c404918b42cf62e7dbdbc9f071d
Gerrit-Change-Number: 57584
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 17 Sep 2021 08:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment