build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45838 )
Change subject: soc/intel/xeon_sp/acpi: Move ACPI macros to a header file ......................................................................
Patch Set 4:
(59 comments)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/acpi_asl.h:
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 6: #define GEN_PCIE_LEGACY_IRQ() \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 7: Package () { 0x0000FFFF, 0x00, LNKA, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 8: Package () { 0x0001FFFF, 0x01, LNKB, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 9: Package () { 0x0002FFFF, 0x02, LNKC, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 10: Package () { 0x0003FFFF, 0x03, LNKD, 0x00 } space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 12: #define GEN_UNCORE_LEGACY_IRQ(dev) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 13: Package () { ##dev, 0x00, LNKA, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 14: Package () { ##dev, 0x01, LNKB, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 15: Package () { ##dev, 0x02, LNKC, 0x00 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 16: Package () { ##dev, 0x03, LNKD, 0x00 } space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 18: #define GEN_PCIE_IOAPIC_IRQ(irq1, irq2, irq3, irq4) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 19: Package () { 0x0000FFFF, 0x00, 0x00, ##irq1 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 20: Package () { 0x0001FFFF, 0x01, 0x00, ##irq2 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 21: Package () { 0x0002FFFF, 0x02, 0x00, ##irq3 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 22: Package () { 0x0003FFFF, 0x03, 0x00, ##irq4 } space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 24: #define GEN_UNCORE_IOAPIC_IRQ(dev,irq1,irq2,irq3,irq4) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 24: #define GEN_UNCORE_IOAPIC_IRQ(dev,irq1,irq2,irq3,irq4) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 24: #define GEN_UNCORE_IOAPIC_IRQ(dev,irq1,irq2,irq3,irq4) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 24: #define GEN_UNCORE_IOAPIC_IRQ(dev,irq1,irq2,irq3,irq4) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 24: #define GEN_UNCORE_IOAPIC_IRQ(dev,irq1,irq2,irq3,irq4) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 25: Package () { ##dev, 0x00, 0x00, ##irq1 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 26: Package () { ##dev, 0x01, 0x00, ##irq2 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 27: Package () { ##dev, 0x02, 0x00, ##irq3 }, \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 28: Package () { ##dev, 0x03, 0x00, ##irq4 } space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 31: #define MAKE_LINK_DEV(id,uid) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 31: #define MAKE_LINK_DEV(id,uid) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 32: Device (LNK##id) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 34: Name (_HID, EISAID ("PNP0C0F")) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 34: Name (_HID, EISAID ("PNP0C0F")) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 35: Name (_UID, ##uid) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 36: Method (_PRS, 0, NotSerialized) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 38: Return (PRS##id) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 40: Method (_CRS, 0, Serialized) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 40: Method (_CRS, 0, Serialized) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 42: Name (RTLA, ResourceTemplate () \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 42: Name (RTLA, ResourceTemplate () \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 44: IRQ (Level, ActiveLow, Shared) {} \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 46: CreateWordField (RTLA, 1, IRQ0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 47: Store (Zero, IRQ0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 50: ShiftLeft (1, And (^^PIR##id, ^^IREM), IRQ0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 50: ShiftLeft (1, And (^^PIR##id, ^^IREM), IRQ0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 50: ShiftLeft (1, And (^^PIR##id, ^^IREM), IRQ0) \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 51: Return (RTLA) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 53: Method (_SRS, 1, Serialized) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 55: CreateWordField (Arg0, 1, IRQ0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 56: FindSetRightBit (IRQ0, Local0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 57: Decrement (Local0) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 58: Store (Local0, ^^PIR##id) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 58: Store (Local0, ^^PIR##id) \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 60: Method (_STA, 0, Serialized) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 62: If (And (^^PIR##id, ^^IREN)) { \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 62: If (And (^^PIR##id, ^^IREN)) { \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 62: If (And (^^PIR##id, ^^IREN)) { \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 63: Return (0x9) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 65: Return (0xb) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 68: Method (_DIS, 0, Serialized) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 70: Or (^^PIR##id, ^^IREN, ^^PIR##id) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 70: Or (^^PIR##id, ^^IREN, ^^PIR##id) \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/45838/4/src/soc/intel/xeon_sp/inclu... PS4, Line 70: Or (^^PIR##id, ^^IREN, ^^PIR##id) \ need consistent spacing around '^' (ctx:WxO)