Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock ......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36914/20/src/cpu/amd/pi/Kconfig File src/cpu/amd/pi/Kconfig:
https://review.coreboot.org/c/coreboot/+/36914/20/src/cpu/amd/pi/Kconfig@55 PS20, Line 55: config PI_AGESA_CAR_HEAP_BASE These will need some argumentation in the commit message.
https://review.coreboot.org/c/coreboot/+/36914/20/src/cpu/x86/lapic/Makefile... File src/cpu/x86/lapic/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36914/20/src/cpu/x86/lapic/Makefile... PS20, Line 4: bootblock-$(CONFIG_UDELAY_LAPIC) += apic_timer.c We'll go with this for now, but some PI blobs manipulate/reset LAPIC so some SOCs may need to switch to TSC. I believe stoney already did.
https://review.coreboot.org/c/coreboot/+/36914/20/src/drivers/amd/agesa/boot... File src/drivers/amd/agesa/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36914/20/src/drivers/amd/agesa/boot... PS20, Line 17: #include <northbridge/amd/agesa/agesa_helper.h> amd_initmmio() is not really about agesa and would be better elsewhere.
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/agesa/... File src/northbridge/amd/agesa/agesa_helper.h:
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/agesa/... PS20, Line 66: These will come from some amdblocks/ headerfile instead. Not really about AGESA.
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... File src/northbridge/amd/pi/nb_util.c:
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... PS20, Line 19: void *get_ap_entry_ptr(void) Make the code in stoney/nb_util.c available under SOC_AMD_COMMON instead of forking a copy.