Hello Felix Held, Angel Pons, Maxim Polyakov, Stefan Reinauer, Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35189
to look at the new patch set (#10).
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
util/inteltool: add many missing registers for skl/kbl
This adds dumping of many registers for Sunrise Point (Skylake/Kaby Lake) that have not been added to inteltool, yet, from doc#332691-003EN and doc#334659-005.
Completely new: - SMBus - APIC - I2C - LPC/eSPI - Thermal Subsystem - USB (XHCI) - GSPI - SPI - PMC
The implementation for Sunrise Point-LP SPI interface could never work because the whole addressing scheme changed. The correct implementation has been added, which works for both Sunrise Point PCH-H and PCH-LP.
The same applies to PMC.
Additionally, inteltool is now able to show the PCI Configuration registers for most of the supported interfaces/subsystems when an appropriate register table is available for the chipset. For Sunrise Point those tables have been added.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6 --- M util/inteltool/Makefile M util/inteltool/ahci.c A util/inteltool/apic.c M util/inteltool/gpio_groups.c A util/inteltool/gspi.c A util/inteltool/i2c.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h A util/inteltool/io.c A util/inteltool/lpc.c M util/inteltool/powermgt.c A util/inteltool/smbus.c M util/inteltool/spi.c A util/inteltool/thermal.c A util/inteltool/usb.c 15 files changed, 2,221 insertions(+), 116 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/35189/10