Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38706/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38706/4//COMMIT_MSG@13
PS4, Line 13: which is linked into ramstage.
Maybe go even further and change compilation of vboot_common.c to be guarded by CONFIG_VBOOT_LIB, not CONFIG_VBOOT? These two callbacks are so generic that they may eventually come up in use cases of the vboot library that aren't tied to verification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0103c5684b3d50ba7dc1b4c39559cb192efa81
Gerrit-Change-Number: 38706
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-Comment-Date: Tue, 04 Feb 2020 20:38:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment