Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34976 )
Change subject: cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34976/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34976/5//COMMIT_MSG@16 PS5, Line 16: the stack_base is at the base of CAR. If the stack grows too large it nit: rewrap lines ?
https://review.coreboot.org/c/coreboot/+/34976/3/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34976/3/src/cpu/intel/car/romstage.... PS3, Line 41: of CAR. To make stack guards useful, move them up 256 bytes */
Official comment style is with * at start of line?
Ah. Crap, this was the proper comment style. Just end the sentence with dot.