Hello Kyösti Mälkki, Eric Peers, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37957
to look at the new patch set (#2).
Change subject: soc/amd/common/block/spi: remove code duplication ......................................................................
soc/amd/common/block/spi: remove code duplication
This removes all the duplicated code and logic and leverages the existing ones in libraries themselves. The current side effect is that protection cannot be fully enabled because the read, write, and write enable command are not exposed in struct spi_flash currently. We can add this later.
BUG=b:146928174 Signed-off-by: Aaron Durbin adurbin@chromium.org
Change-Id: I8faf9cc719ee33dd9f03fb74b579b02bbc6a5e2e --- D src/soc/amd/common/block/include/amdblocks/fch_spi.h M src/soc/amd/common/block/spi/Makefile.inc M src/soc/amd/common/block/spi/fch_spi_ctrl.c D src/soc/amd/common/block/spi/fch_spi_flash.c D src/soc/amd/common/block/spi/fch_spi_special.c D src/soc/amd/common/block/spi/fch_spi_table.c 6 files changed, 33 insertions(+), 704 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/37957/2