Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44265 )
Change subject: ec/google/chromeec: Add dptc interface support
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44265/11/src/ec/google/chromeec/acp...
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/44265/11/src/ec/google/chromeec/acp...
PS11, Line 380: _SB.DPTF.TPET()
Not for this change, but I think we should consolidate these calls to DPTF and DPTC into a single interface going out of the EC. Probably when we move the EC code to SSDT generation, this would be simpler to handle.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2be7942132cea474237f531021ad4fd9856b5050
Gerrit-Change-Number: 44265
Gerrit-PatchSet: 11
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 07:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment