Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38434 )
Change subject: nb/intel/haswell: Do some cosmetic fixes ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... PS7, Line 24: is set to to
oops
Done
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... PS7, Line 117: #define MCHBAR8(x) (*((volatile u8 *)(DEFAULT_MCHBAR + (x))))
I don't mind doing that. […]
Oops... big problem: these macros are used for both reads and writes, so replacing them with the mmio.h accessors won't work:
src/northbridge/intel/haswell/northbridge.c:461:26: error: lvalue required as left operand of assignment 461 | MCHBAR8(BIOS_RESET_CPL) = bios_reset_cpl | ^