Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33400 )
Change subject: util/amdfwtool: Update for Family 17h ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
I'm good making any changes in a follow-on patch
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@800 PS2, Line 800: if (have_bios_level2(table)) : return 1; If having a level 2 table means that we have a level 1, why not just test for level 1 tables?
https://review.coreboot.org/#/c/33400/2/util/amdfwtool/amdfwtool.c@838 PS2, Line 838: continue; for these checks, should we print errors and exit instead of just continuing?