Wuxy - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42184 )
Change subject: mb/google/oak: Add new DRAM modules for oak
......................................................................
Patch Set 21:
(2 comments)
Hi Hung-Te and Paul,
Could you help review this patch and merge?
Thanks.
https://review.coreboot.org/c/coreboot/+/42184/20//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42184/20//COMMIT_MSG@15
PS20, Line 15: TEST=emerge-hana chromeos-ec coreboot chromeos-bootimage depthcharge
What tests did you run?
Add 'memtester' for detail test.
https://review.coreboot.org/c/coreboot/+/42184/20/src/mainboard/google/oak/s...
File src/mainboard/google/oak/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/42184/20/src/mainboard/google/oak/s...
PS20, Line 18:
Only use one space.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95eb51debac905145f16b83c9b74a2bd31dbef45
Gerrit-Change-Number: 42184
Gerrit-PatchSet: 21
Gerrit-Owner: Wuxy -
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tony Lin
tonycwlin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Tue, 14 Jul 2020 01:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment