[coreboot-gerrit] Change in coreboot[master]: fw_config: Add firmware configuration interface

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )

Change subject: fw_config: Add firmware configuration interface
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h 
File src/include/fw_config.h:

https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@9 
PS4, Line 9: #include <static.h>
there is an odd build dependency issue where sometimes the sconfig step doesn't happen at the start and static.h doesn't exist.  I don't see it upstream but it happens every time when building with portage.

https://review.coreboot.org/c/coreboot/+/41209/3/src/lib/Kconfig 
File src/lib/Kconfig:

https://review.coreboot.org/c/coreboot/+/41209/3/src/lib/Kconfig@86 
PS3, Line 86: 	bool
> Initially I was thinking just selected at the mainboard level since it defaulted to trying cbfs firs […]

had to move to src/Kconfig because src/lib/Kconfig can't have prompts..