Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/... File src/mainboard/acer/es1-572/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/... PS5, Line 266: device pci 1f.5 off end # PCH SPI this should be on
Having it off triggers a BUG because pch code depends on SOC_INTEL_COMMON_BLOCK_FAST_SPI which depends on the SPI device being enabled:
~~~ BUG: fast_spi_get_bar requests hidden 00:1f.5 BUG: fast_spi_get_bar requests hidden 00:1f.5 BUG: fast_spi_get_bar requests hidden 00:1f.5 BUG: fast_spi_set_bios_control_reg requests hidden 00:1f.5 BUG: fast_spi_read_post_write requests hidden 00:1f.5 BUG: fast_spi_set_bios_control_reg requests hidden 00:1f.5 BUG: fast_spi_read_post_write requests hidden 00:1f.5 ~~~