Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39423 )
Change subject: mb/google/volteer: Use generic SPD files
......................................................................
Patch Set 4:
(2 comments)
Patch Set 1: Code-Review+1
Silly question: Is the purpose of "generic" SPD files to be vendor-agnostic?
Not a silly question, please see new checkin comment.
https://review.coreboot.org/c/coreboot/+/39423/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39423/2//COMMIT_MSG@7
PS2, Line 7: mb/google/volteer: switch to using generic SPD files
Use generic SPD files
Done
https://review.coreboot.org/c/coreboot/+/39423/2//COMMIT_MSG@8
PS2, Line 8:
Please add why the generic SPD files are preferred.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17bd4f4a00b4e3bbaf845d6d321962c11569a186
Gerrit-Change-Number: 39423
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Mar 2020 01:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment