Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32117 )
Change subject: soc/intel/cannonlake: Vmx support based on Kconfig
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32117/2/src/soc/intel/cannonlake/romstage/fs...
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32117/2/src/soc/intel/cannonlake/romstage/fs...
PS2, Line 64: /* Disable Vmx if Vt-d is already disabled */
Where does this dependency come from? What does the chip.h […]
VT-d is a separate feature from Vmx. Ideally VT-d (Virtualization Technology for Directed I/O) can be used only when VMx is enabled. This check should be removed, or rather enabling/disabling VT-d should be dependent on Vmx being enabled/disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4180c2270038a28befd6ed53c9485905025a15ba
Gerrit-Change-Number: 32117
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Apr 2019 06:12:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment