8 Feb
2019
8 Feb
'19
8:47 a.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/30414/12/src/mainboard/facebook/fbg1701/boot... File src/mainboard/facebook/fbg1701/bootblock.c:
https://review.coreboot.org/#/c/30414/12/src/mainboard/facebook/fbg1701/boot... PS12, Line 27: #
Will change using compiler in update. Changing now will result in build error, […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 12
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 08 Feb 2019 08:47:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Gerrit-MessageType: comment