EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@9
PS2, Line 9: Restore Goodix devicetree config because of the
: missing when moving to override.
Please use the fully allowed text width.
Ack
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@10
PS2, Line 10: missing
Missing what?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f
Gerrit-Change-Number: 32265
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 10 Apr 2019 12:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment