Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 12: #ifndef CONFIG_DPTF_CPU_ADDR : CONFIG_DPTF_CPU_ADDR = 0x00040000ul, : #endif Given that this enum is defined for Participant Type, can we keep the address outside?
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 60: CONFIG_DPTF_CPU_ADDR Since we are using the System Thermal Agent device, can we use it's PCI BDF to construct this address?
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 101: acpigen_write_name_integer("TMPI", id); What is this id? I am not able to find any reference to this Id in the DPTF document that I am looking at - 541817 rev 1.3.13