Attention is currently required from: Raul Rangel, Rob Barnes.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 )
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52143/comment/bd3038fe_3762608e
PS1, Line 118: /* Unmask eSPI IRQ 1 and 12 */
nit: It'd be helpful to comment what these IRQS map to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
Gerrit-Change-Number: 52143
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment