Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47758 )
Change subject: drivers/intel/fsp1_1: Add function to report FSP-T output
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47758/1/src/drivers/intel/fsp1_1/ca...
File src/drivers/intel/fsp1_1/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/47758/1/src/drivers/intel/fsp1_1/ca...
PS1, Line 147: movl %edx, temp_memory_end
: movl %ecx, temp_memory_start
These variables are in .bss which is cleared below. Either you push them on the stack and only .bss below or you temporarily save them in different registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice748e542180f6e1dc1505e7f37b6b6c68772bda
Gerrit-Change-Number: 47758
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 16:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment