Attention is currently required from: Felix Singer, Nico Huber, Sean Rhodes, Matt DeVillier, Paul Menzel, Alexander Couzens.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66380 )
Change subject: ec/lenovo/h8/acpi: Fix wrongly used operator
......................................................................
Patch Set 6: Verified-1
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159782):
https://review.coreboot.org/c/coreboot/+/66380/comment/e5e210f2_1c1fbee3
PS6, Line 8:
Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax")'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159782):
https://review.coreboot.org/c/coreboot/+/66380/comment/c62a65b2_429daf86
PS6, Line 13: Built dsdt.aml of lenovo/x230 and differs, but it remains the same when
Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax")'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43
Gerrit-Change-Number: 66380
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 05 Oct 2022 22:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment