Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42467 )
Change subject: drivers/intel/mipi_camera: SSDT changes to handle camera sensor ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 90: 0); /* endpoint */ nit: could use a macro, #define DEFAULT_ENDPOINT 0, then the comment isn't necessary
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 25: FLASH_DISABLE = 2, Does 1 not mean anything?
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 39: #define CLK_FREQ_19_2MHZ 19200000 : #define CLK_FREQ_24MHZ 24000000 : #define CLK_FREQ_20MHZ 20000000 nit: line up the numbers with tabs
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came... PS2, Line 109: uint8_t reserved[13]; nit: maybe a comment why this was required?